Excavator: Upgrade dependencies #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carterkozak
reviewed
Jan 2, 2024
| assertThatThrownBy(channel.execute(TestEndpoint.POST, request)::get) | ||
| .hasCauseInstanceOf(SocketTimeoutException.class); | ||
| ListenableFuture<Response> response = channel.execute(TestEndpoint.POST, request); | ||
| assertThatThrownBy(() -> response.get()).hasCauseInstanceOf(SocketTimeoutException.class); |
There was a problem hiding this comment.
This assertj upgrade adds an overload to assertThatThrownBy which breaks some method reference inputs. We may want to excavate something to handle this.
In this example I extracted a variable, but it may be easier on the automation if we add a cast to the specific assertj interface type, otherwise the assertThatThrownBy may accept exceptions thrown from a broader snippet than we expect. For example, we want this test to fail if channel.execute throws a SocketTimeoutException, which should only be thrown by response.get().
There was a problem hiding this comment.
Disregard, this has been reverted in assertj: https://github.com/assertj/assertj/releases/tag/assertj-build-3.25.1
carterkozak
approved these changes
Jan 2, 2024
|
Released 3.105.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
excavator is a bot for automating changes across repositories.
Changes produced by the roomba/versions-props-latest check.
To enable or disable this check, please contact the maintainers of Excavator.