-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reason to propagated QoS errors #2093
Conversation
Generate changelog in
|
1685fab
to
e6c8d02
Compare
@@ -57,6 +59,9 @@ public enum ErrorDecoder { | |||
private static final SafeLogger log = SafeLoggerFactory.get(ErrorDecoder.class); | |||
private static final ObjectMapper MAPPER = ObjectMappers.newClientObjectMapper(); | |||
|
|||
@VisibleForTesting | |||
static final QosReason QOS_REASON = QosReason.of("client-qos-response"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't sure what to use for the reason - I'm not particularly in favor of this name and open to suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have anything better in mind, we can likely change this later without breaking folks.
a17bf58
to
2175919
Compare
Released 3.106.0 |
When QoS exceptions are propagated, it would be helpful for the reason to indicate the source of the
QosException
.