Simplify InstrumentedSslConnectionSocketFactory #2094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This takes advantage of an upstream change we made to avoid duplicating logic: apache/httpcomponents-client#499
carterkozak
commented
Jan 3, 2024
| sslSocket.setSoTimeout(handshakeTimeout.toMillisecondsIntBound()); | ||
| } | ||
|
|
||
| prepareSocket(sslSocket); |
There was a problem hiding this comment.
Example of how this can be dangerous -- this prepareSocket method was deprecated in the weeks since we added this instrumented implementation in favor of an overload with an additional HttpContext context parameter. While not breaking, that sort of change can cause us to miss out on bugfixes and new feature support when we replace logic as opposed to wrapping it as this PR does.
bjlaub
approved these changes
Jan 3, 2024
bulldozer-bot
bot
deleted the
ckozak/simplify_SSLConnectionSocketFactory
branch
|
Released 3.107.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==COMMIT_MSG==
Simplify InstrumentedSslConnectionSocketFactory
==COMMIT_MSG==
This takes advantage of an upstream change we made to avoid duplicating logic, which risked falling behind upstream bug fixes:
apache/httpcomponents-client#499