Deserialize endpoint errors

[mpritham]

Before this PR

We'd like to support the a new method in BodySerDe that allows the creation of deserializers given an expected result type, and a set of expected error types.

A ConjureError is serialized and sent by servers. Dialogue deserializes the errors to a SerializableError which loses the type information of the parameters. By providing the type information of the parameters, Dialogue can deserialize the received ConjureError into the well-typed objects (instead of Strings).

After this PR

==COMMIT_MSG==

==COMMIT_MSG==

Possible downsides?

[changelog-app]

Generate changelog in changelog/@unreleased

What do the change types mean?

• feature: A new feature of the service.
• improvement: An incremental improvement in the functionality or operation of the service.
• fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
• break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
  and external consumers of the service's API (e.g. customer-written software or integrations).
• deprecation: Advertises the intention to remove service functionality without any change to the
  operation of the service itself.
• manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
  performing database surgery, ...) at the time of upgrade for it to succeed.
• migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

• ❗The break and manual task changelog types will result in a major release!
• 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
• ✨ All others will result in a minor version release.

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

Check the box to generate changelog(s)

• Generate changelog entry

[carterkozak]

Perhaps we update this to leverage the Encoding with something along these lines?

Encodings.matchesContentType(JSON_ENCODING.getContentType(), contentType.get())

If it's not terribly troublesome, we may want to take the existing json encoding from the configured set of encodings when it's present, and create a new one as a fallback. This way if the client is configured with encodings wrapped to produce metrics/etc, we can retain that functionality.

[carterkozak]

As written we're fully transforming the input json into a JsonNode tree, and reading at most a single string element.
We can define something like this to allow jackson to extract only the pieces of data we're interested in:

private record NamedError(@JsonProperty("errorName") String errorName) {}

[carterkozak]

We don't need to convert the bytestream into a charstream (reader) to then convert back again in the other direction!

Suggested change

	try (Reader reader = new InputStreamReader(body, StandardCharsets.UTF_8)) {
	return CharStreams.toString(reader).getBytes(StandardCharsets.UTF_8);
	}
	try (body) {
	return body.readAllBytes();
	}

[mpritham]

🤦 This was dumb. Fixed.

[carterkozak]

Can we initialize this Deserializer<SerializableError> once above, rather than creating it anew each time it's needed?

[carterkozak]

we can remove public from all the utility methods here, since the class itself is package private

[carterkozak]

Looks solid -- want to start on the codegen piece using an RC?

[mpritham]

Yep. Added do-not-merge. Need a +1 to cut the RC.

[carterkozak]

Approving to cut an RC for iteration with conjure-java codegen 👍

Invalidated by push of ae9dfff