Skip to content

Commit

Permalink
Allow digits in process name (#78)
Browse files Browse the repository at this point in the history
<!-- PR title should start with '[fix]', '[improvement]' or '[break]' if this PR would cause a patch, minor or major SemVer bump. Omit the prefix if this PR doesn't warrant a standalone release. -->

## Before this PR
```
Attaching to build2.palantir.pt
build2.palantir.pt  | Failed to read config files invalid service name 'build2' in static config: process name 'build2' does not match required pattern '^[a-z-]+$'
build2.palantir.pt  | panic: invalid service name 'build2' in static config: process name 'build2' does not match required pattern '^[a-z-]+$'
build2.palantir.pt  |
build2.palantir.pt  | goroutine 1 [running]:
build2.palantir.pt  | main.main()
build2.palantir.pt  |   /go/src/github.com/palantir/go-java-launcher/launcher/main/main.go:98 +0x135c
build2.palantir.pt exited with code 2
```
## After this PR

The above failure doesnt happen
  • Loading branch information
hsaraogi authored and bulldozer-bot[bot] committed Feb 19, 2019
1 parent fd3f80b commit f81a5cd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion launchlib/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import (
)

var (
processNamePattern = regexp.MustCompile("^[a-z-]+$")
processNamePattern = regexp.MustCompile("^[a-z0-9-]+$")
)

type VersionedConfig struct {
Expand Down

0 comments on commit f81a5cd

Please sign in to comment.