Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: Upgrade jennifer dependency #391

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/@unreleased/pr-391.v2.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
type: improvement
improvement:
description: Upgrade jennifer dependency
links:
- https://github.com/palantir/godel-refreshables-plugin/pull/391
4 changes: 2 additions & 2 deletions config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
package config

import (
"io/ioutil"
"os"

v0 "github.com/palantir/godel-refreshables-plugin/config/internal/v0"
"github.com/pkg/errors"
Expand All @@ -19,7 +19,7 @@ func ToConfig(in *Config) *v0.Config {
}

func ReadConfigFromFile(f string) (Config, error) {
bytes, err := ioutil.ReadFile(f)
bytes, err := os.ReadFile(f)
if err != nil {
return Config{}, errors.WithStack(err)
}
Expand Down
14 changes: 7 additions & 7 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module github.com/palantir/godel-refreshables-plugin
go 1.23.0

require (
github.com/dave/jennifer v1.4.1
github.com/dave/jennifer v1.7.1
github.com/palantir/conjure-go-runtime/v2 v2.79.0
github.com/palantir/godel/v2 v2.119.0
github.com/palantir/pkg/cobracli v1.2.0
Expand All @@ -16,16 +16,16 @@ require (
)

require (
github.com/VividCortex/ewma v1.1.1 // indirect
github.com/cheggaaa/pb/v3 v3.0.6 // indirect
github.com/VividCortex/ewma v1.2.0 // indirect
github.com/cheggaaa/pb/v3 v3.1.5 // indirect
github.com/davecgh/go-spew v1.1.1 // indirect
github.com/fatih/color v1.13.0 // indirect
github.com/fatih/color v1.17.0 // indirect
github.com/golang/snappy v0.0.4 // indirect
github.com/inconshreveable/mousetrap v1.1.0 // indirect
github.com/kr/pretty v0.2.0 // indirect
github.com/mattn/go-colorable v0.1.13 // indirect
github.com/mattn/go-isatty v0.0.19 // indirect
github.com/mattn/go-runewidth v0.0.10 // indirect
github.com/mattn/go-isatty v0.0.20 // indirect
github.com/mattn/go-runewidth v0.0.16 // indirect
github.com/nmiyake/pkg/errorstringer v1.1.0 // indirect
github.com/palantir/go-metrics v1.1.1 // indirect
github.com/palantir/pkg v1.1.0 // indirect
Expand All @@ -43,7 +43,7 @@ require (
github.com/palantir/witchcraft-go-params v1.36.0 // indirect
github.com/palantir/witchcraft-go-tracing v1.38.0 // indirect
github.com/pmezard/go-difflib v1.0.0 // indirect
github.com/rivo/uniseg v0.1.0 // indirect
github.com/rivo/uniseg v0.4.7 // indirect
github.com/spf13/pflag v1.0.5 // indirect
go.uber.org/zap v1.17.0 // indirect
golang.org/x/mod v0.21.0 // indirect
Expand Down
40 changes: 15 additions & 25 deletions go.sum

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions plugin/plugin.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (
"bytes"
"go/token"
"go/types"
"io/ioutil"
"os"
"path/filepath"
"strings"
Expand Down Expand Up @@ -83,7 +82,7 @@ func renderRefreshableTypesFile(projectDir string, importAliases map[string]stri
return err
}
if verify {
existing, err := ioutil.ReadFile(outputFile)
existing, err := os.ReadFile(outputFile)
if os.IsNotExist(err) {
return errors.Wrap(err, "regenerate refreshables output")
}
Expand All @@ -94,7 +93,7 @@ func renderRefreshableTypesFile(projectDir string, importAliases map[string]stri
if err := os.MkdirAll(filepath.Dir(outputFile), 0755); err != nil {
return errors.Wrap(err, "create outputFile parent directories")
}
if err := ioutil.WriteFile(outputFile, outputBytes, 0644); err != nil {
if err := os.WriteFile(outputFile, outputBytes, 0644); err != nil {
return errors.Wrap(err, "write outputFile")
}
}
Expand Down
1 change: 1 addition & 0 deletions vendor/github.com/VividCortex/ewma/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions vendor/github.com/VividCortex/ewma/.whitesource

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 17 additions & 12 deletions vendor/github.com/VividCortex/ewma/README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions vendor/github.com/VividCortex/ewma/codecov.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

69 changes: 53 additions & 16 deletions vendor/github.com/cheggaaa/pb/v3/element.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 17 additions & 1 deletion vendor/github.com/cheggaaa/pb/v3/pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading