Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark methods using squareup javapoet as deprecated #559

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Mark methods using squareup javapoet as deprecated #559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2100d18
Mark methods using squareup javapoet as deprecated
ash211 Nov 5, 2024
7e8743b
Add generated changelog entries
svc-changelog Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/@unreleased/pr-559.v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
type: improvement
improvement:
description: Mark methods using squareup javapoet as deprecated
links:
- https://github.com/palantir/goethe/pull/559
6 changes: 6 additions & 0 deletions goethe/src/main/java/com/palantir/goethe/Goethe.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ public static String formatAsString(com.palantir.javapoet.JavaFile file) {
*
* @param file Javapoet file to format
* @return Formatted source code
* @deprecated Use {@link #formatAsString(com.palantir.javapoet.JavaFile)} instead.
*/
@Deprecated
public static String formatAsString(com.squareup.javapoet.JavaFile file) {
StringBuilder rawSource = new StringBuilder();
try {
Expand Down Expand Up @@ -110,7 +112,9 @@ public static void formatAndEmit(com.palantir.javapoet.JavaFile file, Filer file
*
* @param file Javapoet file to format
* @param filer Destination for the formatted file
* @deprecated Use {@link #formatAndEmit(com.palantir.javapoet.JavaFile, Filer)} instead.
*/
@Deprecated
public static void formatAndEmit(com.squareup.javapoet.JavaFile file, Filer filer) {
String formatted = formatAsString(file);

Expand Down Expand Up @@ -160,7 +164,9 @@ public static Path formatAndEmit(com.palantir.javapoet.JavaFile file, Path baseD
* @param file Javapoet file to format
* @param baseDir Source set root where the formatted file will be written
* @return the new file location
* @deprecated Use {@link #formatAndEmit(com.palantir.javapoet.JavaFile, Path)} instead.
*/
@Deprecated
public static Path formatAndEmit(com.squareup.javapoet.JavaFile file, Path baseDir) {
String formatted = formatAsString(file);
try {
Expand Down