Merge pull request #61 from j-baker/dfe

Remove DesignForExtension checkstyle, add Antipatterns FindBugs
palantir · Jul 6, 2016 · 5dbcdae · 5dbcdae
2 parents db711b8 + 70858a0
commit 5dbcdae
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -193,6 +193,14 @@ The BUG_PATTERN_NAME can be derived from the "Pattern" field in the Eclipse Bug
 More complicated filters can be handled via the `.baseline/findbugs/excludeFilter.xml` file; see [FindBugs
 documentation](http://findbugs.sourceforge.net/manual/filter.html) for details.
 
+We apply the [antipatterns](https://github.com/palantir/antipatterns) Gradle plugin; if you wish to change
+the version of this plugin, please do so by adding
+
+    dependencies {
+        findbugsPlugins "com.palantir.antipatterns:$antipatternsVersion"
+    }
+
+to your project dependencies.
 
 ### Jacoco Coverage Plugin (jacoco-coverage)
 

diff --git a/gradle-baseline-java-config/resources/checkstyle/checkstyle.xml b/gradle-baseline-java-config/resources/checkstyle/checkstyle.xml
@@ -355,7 +355,6 @@
             <property name="target" value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"/>
         </module>
         <module name="CyclomaticComplexity"/> <!-- Java Coding Guidelines: Reduce Cyclomatic Complexity -->
-        <module name="DesignForExtension"/> <!-- Java Coding Guidelines: Design for extension -->
         <module name="JavadocMethod"> <!-- Java Style Guide: Where Javadoc is used -->
             <property name="scope" value="public"/>
             <property name="allowMissingParamTags" value="true"/>

diff --git a/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineFindBugs.groovy b/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineFindBugs.groovy
@@ -30,6 +30,7 @@ class BaselineFindBugs extends AbstractBaselinePlugin {
 
     private static final String DEFAULT_FINDBUGS_VERSION = '3.0.1'
     private static final String DEFAULT_EFFORT = 'max'
+    private static final String ANTIPATTERNS_ARTIFACT = 'com.palantir.antipatterns:antipatterns:1.0-beta.4'
 
     void apply(Project project) {
         this.project = project
@@ -65,6 +66,10 @@ class BaselineFindBugs extends AbstractBaselinePlugin {
             excludeFilter = excludeFilterFile
             effort = DEFAULT_EFFORT
         }
+
+        project.dependencies {
+            findbugsPlugins ANTIPATTERNS_ARTIFACT
+        }
     }
 
     // Configure checkstyle settings for Eclipse