Skip to content

Commit

Permalink
More careful checkstyle regex for todos (#237)
Browse files Browse the repository at this point in the history
The current regex erroneously catches // TODO(dtrump): Make america() return GREAT again.
  • Loading branch information
kyegupov authored and iamdanfox committed Mar 16, 2018
1 parent 5d90aba commit d5cddee
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .baseline/checkstyle/checkstyle.xml
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@
<property name="message" value="Redundant ''static'' modifier."/>
</module>
<module name="RegexpSinglelineJava">
<property name="format" value="(\/\/TODO)|(\/\/ TODO:)|(\/\/ TODO\(\))|(\/\/ TODO\(.*\):[^ ])|(\/\/ TODO\(.*\)[^:])"/>
<property name="format" value="(\/\/TODO)|(\/\/ TODO:)|(\/\/ TODO\(\))|(\/\/ TODO\([a-z]*\):[^ ])|(\/\/ TODO\([a-z]*\)[^:])"/>
<property name="message" value="TODO format: // TODO(flastname): explanation"/>
</module>
<module name="RegexpSinglelineJava">
Expand Down

0 comments on commit d5cddee

Please sign in to comment.