Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Baseline and Error Prone #2840

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Upgrade Baseline and Error Prone #2840

merged 1 commit into from
Aug 19, 2024

Conversation

pkoenig10
Copy link
Member

@pkoenig10 pkoenig10 commented Aug 19, 2024

See #2839

@pkoenig10 pkoenig10 requested a review from carterkozak August 19, 2024 15:29
@pkoenig10 pkoenig10 marked this pull request as ready for review August 19, 2024 15:29
@pkoenig10 pkoenig10 changed the base branch from pkoenig/defaultLocale to develop August 19, 2024 15:29
@@ -0,0 +1 @@
(c) Copyright ${today.year} Palantir Technologies Inc. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be added

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm this was generated by baselineUpdateConfig, will figure out why.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also generated if you run baselineUpdateConfig on develop. I can remove it here, but I suspect that an excavator will automatically generate it in the future.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The excavator deletes new copyright files added by the task, when running the update task we need to do that step manually

@bulldozer-bot bulldozer-bot bot merged commit 323e2bf into develop Aug 19, 2024
5 checks passed
@bulldozer-bot bulldozer-bot bot deleted the pkoenig/upgrade branch August 19, 2024 16:21
@svc-autorelease
Copy link
Collaborator

Released 5.63.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants