Avoid empty lines in the middle of the manifest when shading a multi-release jar #77
Conversation
Generate changelog in
|
| import static java.util.jar.JarFile.* | ||
|
|
||
| // Originally taken from https://github.com/johnrengelman/shadow/blob/6.1.0/src/main/groovy/com/github/jengelman/ | ||
| // gradle/plugins/shadow/transformers/ManifestAppenderTransformer.groovy |
There was a problem hiding this comment.
surely we should just be PRing this upstream to mr johnrengelman?
There was a problem hiding this comment.
I'm happy to do this if you think that makes sense, though was a bit concerned as to timescales since the last thing was merged in early October!
There was a problem hiding this comment.
I'll PR this upstream, but also think we should get this through here as we need it for atlasdb-proxy's migrations and I don't know how actively the shadow plugin is maintained (as mentioned, the last time anything was merged was in early October, and there is a 26 day old PR that has seen no response)
There was a problem hiding this comment.
I'm happy to merge this as @jeremyk-91 has opened GradleUp/shadow#620 so hopefully we can delete our version of this code if that gets merged :)
|
Released 1.3.2 |
Before this PR
#76 was a problem
After this PR
#76 should be fixed.
Possible downsides?
Is there a case I've missed out on / where the blank lines I'm removing lose semantic information?
The test I've added is a bit weak.