review comments

palantir · Jul 20, 2024 · 18ead79 · 18ead79
1 parent 22087a3
commit 18ead79
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 19 deletions.
diff --git a/packages/client.api/src/index.ts b/packages/client.api/src/index.ts
@@ -14,8 +14,6 @@
  * limitations under the License.
  */
 
-import { TimeseriesDurationMapping } from "./timeseries/timeseries.js";
-
 export type { ActionReturnTypeForOptions } from "./actions/ActionReturnTypeForOptions.js";
 export type {
   ActionEditResponse,

diff --git a/packages/client/src/createTimeseriesProperty.ts b/packages/client/src/createTimeseriesProperty.ts
@@ -89,21 +89,16 @@ async function getAllTimeSeriesPoints<T extends string | number>(
   propertyName: string,
   body: TimeSeriesQuery,
 ): Promise<Array<TimeSeriesPoint<T>>> {
-  const streamPointsIterator = await OntologiesV2.OntologyObjectsV2
-    .streamPoints(
+  const allPoints: Array<TimeSeriesPoint<T>> = [];
+
+  for await (
+    const point of iterateTimeSeriesPoints(
       client,
-      await client.ontologyRid,
       objectApiName,
       primaryKey,
       propertyName,
-      { range: getTimeRange(body) },
-    );
-
-  const allPoints: Array<TimeSeriesPoint<T>> = [];
-
-  const reader = streamPointsIterator.stream().getReader();
-  for await (
-    const point of parseStreamedResponse(iterateReadableStream(reader))
+      body,
+    )
   ) {
     allPoints.push({
       time: point.time,

diff --git a/packages/client/src/object/convertWireToOsdkObjects/createOsdkInterface.ts b/packages/client/src/object/convertWireToOsdkObjects/createOsdkInterface.ts
@@ -49,10 +49,6 @@ export function createOsdkInterface<
     [InterfaceDefRef]: interfaceDef,
   };
 
-  if (process.env.TARGET !== "browser") {
-    Object.setPrototypeOf(interfaceHolder, null);
-  }
-
   const handler = handlerCache.get(interfaceDef);
 
   const proxy = new Proxy<OsdkObject<any>>(

diff --git a/packages/client/src/object/convertWireToOsdkObjects/createOsdkObject.ts b/packages/client/src/object/convertWireToOsdkObjects/createOsdkObject.ts
@@ -33,13 +33,12 @@ import type {
   ObjectHolder,
   ObjectHolderPrototypeOwnProps,
 } from "./ObjectHolder.js";
-import { OsdkCustomInspectPrototype } from "./OsdkCustomInspectPrototype.js";
 import type { PropertyDescriptorRecord } from "./PropertyDescriptorRecord.js";
 
 const objectPrototypeCache = createClientCache(
   function(client, objectDef: FetchedObjectTypeDefinition<any, any>) {
     return Object.create(
-      process.env.target !== "browser" ? null : null,
+      null,
       {
         [ObjectDefRef]: { value: objectDef },
         [ClientRef]: { value: client },