Fix primary key encoding (#524)

* fix primary key encoding * add changeset
palantir · Jul 25, 2024 · 234de07 · 234de07
1 parent fdaf141
commit 234de07
Show file tree

Hide file tree

Showing 9 changed files with 13 additions and 8 deletions.
diff --git a/.changeset/mean-dragons-stare.md b/.changeset/mean-dragons-stare.md
@@ -0,0 +1,5 @@
+---
+"@osdk/legacy-client": patch
+---
+
+Fix primary key encoding in URLs
diff --git a/packages/legacy-client/src/client/net/getAllTimeSeriesPoints.ts b/packages/legacy-client/src/client/net/getAllTimeSeriesPoints.ts
@@ -46,7 +46,7 @@ export async function getAllTimeSeriesPoints<T extends string | number>(
         createOpenApiRequest(client.stack, client.fetch, undefined, true),
         client.ontology.metadata.ontologyApiName,
         apiName,
-        primaryKey,
+        encodeURIComponent(primaryKey),
         propertyName,
         body,
       );

diff --git a/packages/legacy-client/src/client/net/getFirstPoint.ts b/packages/legacy-client/src/client/net/getFirstPoint.ts
@@ -38,7 +38,7 @@ export async function getFirstPoint<T extends string | number>(
         createOpenApiRequest(client.stack, client.fetch),
         client.ontology.metadata.ontologyApiName,
         objectApiName,
-        primaryKey,
+        encodeURIComponent(primaryKey),
         propertyName,
       );
       return {

diff --git a/packages/legacy-client/src/client/net/getLastPoint.ts b/packages/legacy-client/src/client/net/getLastPoint.ts
@@ -38,7 +38,7 @@ export async function getLastPoint<T extends string | number>(
         createOpenApiRequest(client.stack, client.fetch),
         client.ontology.metadata.ontologyApiName,
         objectApiName,
-        primaryKey,
+        encodeURIComponent(primaryKey),
         propertyName,
       );
       return {

diff --git a/packages/legacy-client/src/client/net/getLinkedObject.ts b/packages/legacy-client/src/client/net/getLinkedObject.ts
@@ -65,7 +65,7 @@ export async function getLinkedObjectNoErrors<T extends OntologyObject>(
     createOpenApiRequest(client.stack, client.fetch),
     client.ontology.metadata.ontologyApiName,
     sourceApiName,
-    primaryKey,
+    encodeURIComponent(primaryKey),
     linkTypeApiName,
     linkedObjectPrimaryKey,
     {

diff --git a/packages/legacy-client/src/client/net/getLinkedObjectsPage.ts b/packages/legacy-client/src/client/net/getLinkedObjectsPage.ts
@@ -33,7 +33,7 @@ export async function getLinkedObjectsPage<T extends OntologyObject>(
     createOpenApiRequest(client.stack, client.fetch),
     client.ontology.metadata.ontologyApiName,
     sourceApiName,
-    primaryKey,
+    encodeURIComponent(primaryKey),
     linkTypeApiName,
     {
       pageSize: options?.pageSize,

diff --git a/packages/legacy-client/src/client/net/getObject.ts b/packages/legacy-client/src/client/net/getObject.ts
@@ -57,7 +57,7 @@ export async function getObjectWithoutErrors<T extends OntologyObject>(
     createOpenApiRequest(client.stack, client.fetch),
     client.ontology.metadata.ontologyApiName,
     objectApiName,
-    primaryKey.toString(),
+    encodeURIComponent(primaryKey.toString()),
     {
       select: selectedProperties.map(x => x.toString()),
     },

diff --git a/packages/legacy-client/src/client/net/iterateTimeSeriesPoints.ts b/packages/legacy-client/src/client/net/iterateTimeSeriesPoints.ts
@@ -43,7 +43,7 @@ export async function* iterateTimeSeriesPoints<T extends string | number>(
         createOpenApiRequest(client.stack, client.fetch, undefined, true),
         client.ontology.metadata.ontologyApiName,
         apiName,
-        primaryKey,
+        encodeURIComponent(primaryKey),
         propertyName,
         body,
       );

diff --git a/packages/legacy-client/src/client/net/util/iterateLinkedObjects.ts b/packages/legacy-client/src/client/net/util/iterateLinkedObjects.ts
@@ -36,7 +36,7 @@ export async function* iterateLinkedObjects<T extends OntologyObject>(
       createOpenApiRequest(client.stack, client.fetch),
       client.ontology.metadata.ontologyApiName,
       sourceApiName,
-      primaryKey,
+      encodeURIComponent(primaryKey),
       linkTypeApiName,
       {
         pageSize: options?.pageSize,