More interface args cleanup (#949)

* clean up args * add changeset'
palantir · Nov 1, 2024 · 27866a8 · 27866a8
1 parent f5dfdde
commit 27866a8
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 12 deletions.
diff --git a/.changeset/rare-brooms-move.md b/.changeset/rare-brooms-move.md
@@ -0,0 +1,6 @@
+---
+"@osdk/client": patch
+"@osdk/api": patch
+---
+
+Removing interface argument for selecting object types. This is not supported in the new apis, and is not being used internally anywhere with the old apis.
diff --git a/etc/api.report.api.md b/etc/api.report.api.md
@@ -191,8 +191,6 @@ export type ApplyBatchActionOptions = {
 //
 // @public (undocumented)
 export interface AsyncIterArgs<Q extends ObjectOrInterfaceDefinition, K extends PropertyKeys<Q> = PropertyKeys<Q>, R extends boolean = false, A extends Augments = never, S extends NullabilityAdherence = NullabilityAdherence.Default> extends SelectArg<Q, K, R, S>, OrderByArg<Q, PropertyKeys<Q>> {
-    // (undocumented)
-    $__EXPERIMENTAL_selectedObjectTypes?: string[];
 }
 
 // @public (undocumented)

diff --git a/packages/api/src/object/FetchPageArgs.ts b/packages/api/src/object/FetchPageArgs.ts
@@ -70,7 +70,6 @@ export interface AsyncIterArgs<
   A extends Augments = never,
   S extends NullabilityAdherence = NullabilityAdherence.Default,
 > extends SelectArg<Q, K, R, S>, OrderByArg<Q, PropertyKeys<Q>> {
-  $__EXPERIMENTAL_selectedObjectTypes?: string[];
 }
 
 export type Augment<

diff --git a/packages/client/src/object/fetchPage.ts b/packages/client/src/object/fetchPage.ts
@@ -102,7 +102,7 @@ async function fetchInterfacePage<
         augmentedProperties: {},
         augmentedSharedPropertyTypes: {},
         otherInterfaceTypes: [],
-        selectedObjectTypes: args.$__EXPERIMENTAL_selectedObjectTypes ?? [],
+        selectedObjectTypes: [],
         selectedSharedPropertyTypes: args.$select as undefined | string[] ?? [],
         where: objectSetToSearchJsonV2(objectSet, interfaceType.apiName),
       }),

diff --git a/packages/e2e.sandbox.catchall/src/runInterfacesTest.ts b/packages/e2e.sandbox.catchall/src/runInterfacesTest.ts
@@ -31,15 +31,15 @@ export async function runInterfacesTest() {
 
   const qqq = await client(FooInterface).where({ name: { $ne: "Patti" } });
 
-  const fooLimitedToEmployees = await client(FooInterface).fetchPage({
-    $__EXPERIMENTAL_selectedObjectTypes: ["Employee"],
-  });
-  invariant(fooLimitedToEmployees.data.length > 0);
+  // const fooLimitedToEmployees = await client(FooInterface).fetchPage({
+  //   $__EXPERIMENTAL_selectedObjectTypes: ["Employee"],
+  // });
+  // invariant(fooLimitedToEmployees.data.length > 0);
 
-  const fooLimitedToOther = await client(FooInterface).fetchPage({
-    $__EXPERIMENTAL_selectedObjectTypes: ["Other"],
-  });
-  invariant(fooLimitedToOther.data.length === 0);
+  // const fooLimitedToOther = await client(FooInterface).fetchPage({
+  //   $__EXPERIMENTAL_selectedObjectTypes: ["Other"],
+  // });
+  // invariant(fooLimitedToOther.data.length === 0);
 
   const r = await client(FooInterface)
     .where({ name: { $ne: "Patti" } })