Merge pull request #95 from palantir/ssanjay/dateTimeFilter

Fix datetime where clause
palantir · Feb 27, 2024 · 39c0324 · 39c0324
2 parents b1584b3 + 1943a47
commit 39c0324
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/packages/client/changelog/@unreleased/pr-95.v2.yml b/packages/client/changelog/@unreleased/pr-95.v2.yml
@@ -0,0 +1,5 @@
+type: feature
+feature:
+  description: Fix datetime where clause
+  links:
+  - https://github.com/palantir/osdk-ts/pull/95
diff --git a/packages/client/src/query/WhereClause.ts b/packages/client/src/query/WhereClause.ts
@@ -50,6 +50,10 @@ type NumberFilter =
   | BaseFilter<number>
   | MakeFilter<"$gt" | "$gte" | "$lt" | "$lte", number>;
 
+type DatetimeFilter =
+  | BaseFilter<string>
+  | MakeFilter<"$gt" | "$gte" | "$lt" | "$lte", string>;
+
 export const DistanceUnitMapping = {
   "centimeter": "CENTIMETERS",
   "centimeters": "CENTIMETERS",
@@ -106,6 +110,7 @@ export type GeoFilter = GeoFilter_Within | GeoFilter_Intersects;
 type FilterFor<PD extends ObjectTypePropertyDefinition> = PD["type"] extends
   "string" ? StringFilter
   : PD["type"] extends "geopoint" | "geoshape" ? GeoFilter
+  : PD["type"] extends "datetime" | "timestamp" ? DatetimeFilter
   : NumberFilter; // FIXME we need to represent all types
 
 export interface AndWhereClause<