Cherrypick interface generator fix (#935)

* Interfaces w no props fix

* changeset

.changeset/pink-eyes-trade.md

@@ -0,0 +1,5 @@
+---
+"@osdk/generator": patch
+---
+
+Fixes generation for interfaces with no properties

packages/e2e.generated.catchall/ontology.json

@@ -923,8 +923,18 @@
       },
       "rid": "ri.ontology.main.interface-type.1b1b1b1b-1b1b-1b1b-1b1b-1b1b1b1b1b1b",
       "status": "ACTIVE"
+    },
+    "InterfaceNoProps": {
+      "apiName": "InterfaceNoProps",
+      "displayName": "FInterfaceNoProps",
+      "description": "Its a Foo.",
+      "properties": {
+      },
+      "rid": "ri.ontology.main.interface-type.1b1b1b1b-1b1b-1b1b-1b1b-1b1b1b1b1b1b",
+      "status": "ACTIVE"
     }
   },
+
   "sharedPropertyTypes": {
     "name": {
       "rid": "ri.ontology.main.shared-property.6618a6fc-5f14-4899-9540-615c9364c5d6",

packages/e2e.generated.catchall/src/generatedNoCheck/index.ts

@@ -1,6 +1,6 @@
 export { actionTakesAllParameterTypes, assignEmployee1, createTodo } from './ontology/actions.js';
 export * as $Actions from './ontology/actions.js';
-export { FooInterface } from './ontology/interfaces.js';
+export { FooInterface, InterfaceNoProps } from './ontology/interfaces.js';
 export * as $Interfaces from './ontology/interfaces.js';
 export {
   BoundariesUsState,

packages/e2e.generated.catchall/src/generatedNoCheck/ontology/interfaces.ts

@@ -1 +1,2 @@
 export { FooInterface } from './interfaces/FooInterface.js';
+export { InterfaceNoProps } from './interfaces/InterfaceNoProps.js';

packages/e2e.generated.catchall/src/generatedNoCheck/ontology/interfaces/InterfaceNoProps.ts

@@ -0,0 +1,56 @@
+import type { PropertyDef as $PropertyDef } from '@osdk/api';
+import { $osdkMetadata } from '../../OntologyMetadata.js';
+
+import type {
+  InterfaceDefinition as $InterfaceDefinition,
+  ObjectSet as $ObjectSet,
+  Osdk as $Osdk,
+  PropertyValueWireToClient as $PropType,
+} from '@osdk/api';
+
+export type OsdkObjectLinks$InterfaceNoProps = {};
+
+export namespace InterfaceNoProps {
+  export type PropertyKeys = never;
+
+  export interface Props {}
+  export type StrictProps = Props;
+
+  export interface ObjectSet extends $ObjectSet<InterfaceNoProps, InterfaceNoProps.ObjectSet> {}
+
+  export type OsdkInstance<
+    OPTIONS extends never | '$rid' = never,
+    K extends keyof InterfaceNoProps.Props = keyof InterfaceNoProps.Props,
+  > = $Osdk.Instance<InterfaceNoProps, OPTIONS, K>;
+
+  /** @deprecated use OsdkInstance */
+  export type OsdkObject<
+    OPTIONS extends never | '$rid' = never,
+    K extends keyof InterfaceNoProps.Props = keyof InterfaceNoProps.Props,
+  > = OsdkInstance<OPTIONS, K>;
+}
+
+export interface InterfaceNoProps extends $InterfaceDefinition {
+  osdkMetadata: typeof $osdkMetadata;
+  type: 'interface';
+  apiName: 'InterfaceNoProps';
+  __DefinitionMetadata?: {
+    objectSet: InterfaceNoProps.ObjectSet;
+    props: InterfaceNoProps.Props;
+    linksType: OsdkObjectLinks$InterfaceNoProps;
+    strictProps: InterfaceNoProps.StrictProps;
+    apiName: 'InterfaceNoProps';
+    description: 'Its a Foo.';
+    displayName: 'FInterfaceNoProps';
+    links: {};
+    properties: {};
+    rid: 'ri.ontology.main.interface-type.1b1b1b1b-1b1b-1b1b-1b1b-1b1b1b1b1b1b';
+    type: 'interface';
+  };
+}
+
+export const InterfaceNoProps: InterfaceNoProps = {
+  type: 'interface',
+  apiName: 'InterfaceNoProps',
+  osdkMetadata: $osdkMetadata,
+};

packages/generator/src/v2.0/wireObjectTypeV2ToSdkObjectConstV2.ts

@@ -346,9 +346,12 @@ ${
 export function createPropertyKeys(
   type: EnhancedObjectType | EnhancedInterfaceType,
 ) {
+  const properties = Object.keys(type.getCleanedUpDefinition(true).properties);
   return `export type PropertyKeys = ${
-    Object.keys(type.getCleanedUpDefinition(true).properties).map(
-      (a) => maybeStripNamespace(type, a),
-    ).map(a => `"${a}"`).join("|")
+    properties.length === 0
+      ? "never"
+      : properties.map(
+        (a) => maybeStripNamespace(type, a),
+      ).map(a => `"${a}"`).join("|")
   };`;
 }