Enable eslint eqeqeq rule (#62)

palantir · Feb 15, 2024 · 96085fa · 96085fa
1 parent e2964be
commit 96085fa
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 10 deletions.
diff --git a/examples/basic/cli/src/index.ts b/examples/basic/cli/src/index.ts
@@ -27,8 +27,8 @@ import { fetchEmployeePageByAdUsernameAndLimit } from "./examples/fetchEmployeeP
 import { fetchEmployeePageThin } from "./examples/fetchEmployeePageThin.js";
 import { typeChecks } from "./typeChecks.js";
 
-invariant(process.env.FOUNDRY_STACK != undefined);
-invariant(process.env.FOUNDRY_USER_TOKEN != undefined);
+invariant(process.env.FOUNDRY_STACK !== undefined);
+invariant(process.env.FOUNDRY_USER_TOKEN !== undefined);
 
 /**
  * TLDR: If you're starting out, just use `client` and ignore ` clientCtx`.

diff --git a/monorepo/eslint-config-sane/library.cjs b/monorepo/eslint-config-sane/library.cjs
@@ -26,6 +26,8 @@ module.exports = {
   rules: {
     "@typescript-eslint/consistent-type-imports": "error",
 
+    eqeqeq: ["error", "always", { null: "never" }],
+
     "header/header": [
       2,
       "block",

diff --git a/packages/client/src/internal/conversions/legacyToModernSingleAggregationResult.ts b/packages/client/src/internal/conversions/legacyToModernSingleAggregationResult.ts
@@ -31,7 +31,7 @@ export function legacyToModernSingleAggregationResult<
     (accumulator, curValue) => {
       const parts = curValue.name.split(".");
       invariant(
-        parts.length == 2,
+        parts.length === 2,
         "assumed we were getting a `${key}.${type}`",
       );
       if (!(parts[0] in accumulator)) {

diff --git a/packages/generator/src/shared/wireObjectTypeV2ToSdkObjectConst.ts b/packages/generator/src/shared/wireObjectTypeV2ToSdkObjectConst.ts
@@ -33,7 +33,7 @@ export function wireObjectTypeV2ToSdkObjectConst(
   );
 
   const imports = Array.from(uniqueLinkTargetTypes).filter(type =>
-    type != definition.apiName
+    type !== definition.apiName
   ).map(type => `import type { ${type}Def } from "./${type}${importExt}";`);
 
   return `

diff --git a/packages/generator/src/shared/wireQueryDataTypeToQueryDataTypeDefinition.ts b/packages/generator/src/shared/wireQueryDataTypeToQueryDataTypeDefinition.ts
@@ -79,7 +79,7 @@ export function wireQueryDataTypeToQueryDataTypeDefinition<K extends string>(
 
       // special case for a union where one half is nullable to skip the union step and just allow nulls directly
       if (allowNulls && input.unionTypes.length === 2) {
-        const nonnull = input.unionTypes.find(t => t.type !== null);
+        const nonnull = input.unionTypes.find(t => t.type != null);
         if (nonnull) {
           return {
             ...wireQueryDataTypeToQueryDataTypeDefinition(nonnull),

diff --git a/packages/legacy-client/src/client/net/getOnlyLinkedObject.ts b/packages/legacy-client/src/client/net/getOnlyLinkedObject.ts
@@ -44,7 +44,7 @@ export async function getOnlyLinkedObject<
     return result;
   }
 
-  if (result.type == "ok" && result.value.length > 1) {
+  if (result.type === "ok" && result.value.length > 1) {
     return createErrorResponse(
       {
         name: "Too many objects",
@@ -61,7 +61,7 @@ export async function getOnlyLinkedObject<
     );
   }
 
-  if (result.type == "ok" && result.value.length != 1) {
+  if (result.type === "ok" && result.value.length !== 1) {
     return createErrorResponse(
       {
         name: "Object not found",

diff --git a/packages/legacy-client/src/client/objects/convertWireToOsdkObject.ts b/packages/legacy-client/src/client/objects/convertWireToOsdkObject.ts
@@ -84,7 +84,7 @@ function createPrototype<
     Object.defineProperty(proto, k, {
       get: function() {
         const client = this[OriginClient] as ClientContext<any>;
-        if (multiplicity == true) {
+        if (multiplicity === true) {
           return createMultiLinkStep(
             client,
             objDef.apiName,

diff --git a/packages/shared.test/src/handlers/loadObjectsEndpoints.ts b/packages/shared.test/src/handlers/loadObjectsEndpoints.ts
@@ -253,10 +253,10 @@ export const loadObjectsEndpoints: RestHandler<
         }
 
         const paginationParams = {
-          pageSize: req.url.searchParams.get("pageSize") === null
+          pageSize: req.url.searchParams.get("pageSize") == null
             ? undefined
             : Number(req.url.searchParams.get("pageSize")),
-          pageToken: req.url.searchParams.get("pageToken") === null
+          pageToken: req.url.searchParams.get("pageToken") == null
             ? undefined
             : (req.url.searchParams.get("pageToken") as string),
         };