Adding data constraints which are required for markings (#962)

* Adding data constraints which are required for markings * Add tests * fix --------- Co-authored-by: Alex Parson <[email protected]>
palantir · Nov 7, 2024 · b8a1a58 · b8a1a58
1 parent 0cd1603
commit b8a1a58
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 3 deletions.
diff --git a/.changeset/silent-jokes-matter.md b/.changeset/silent-jokes-matter.md
@@ -0,0 +1,5 @@
+---
+"@osdk/maker": minor
+---
+
+Add nullability to markings because of course they need to be nullable. This sucks in the data model, I should talk to the ontology team about this.
diff --git a/packages/maker/src/api/defineOntology.ts b/packages/maker/src/api/defineOntology.ts
@@ -164,6 +164,15 @@ function convertSpt(
     valueType,
   }: SharedPropertyType,
 ): OntologyIrSharedPropertyType {
+  const dataConstraint:
+    | OntologyIrSharedPropertyType["dataConstraints"]
+    | undefined = (typeof type === "object" && type.type === "marking")
+      ? {
+        propertyTypeConstraints: [],
+        nullability: undefined,
+        nullabilityV2: { noEmptyCollections: true, noNulls: true },
+      }
+      : undefined;
   return {
     apiName,
     displayMetadata: {
@@ -181,7 +190,7 @@ function convertSpt(
       : convertType(type),
     aliases: [],
     baseFormatter: undefined,
-    dataConstraints: undefined,
+    dataConstraints: dataConstraint,
     gothamMapping: gothamMapping,
     indexedForSearch: true,
     provenance: undefined,

diff --git a/packages/maker/src/api/overall.test.ts b/packages/maker/src/api/overall.test.ts
@@ -1185,7 +1185,14 @@ describe("Ontology Defining", () => {
                   "aliases": [],
                   "apiName": "com.palantir.foo",
                   "baseFormatter": undefined,
-                  "dataConstraints": undefined,
+                  "dataConstraints": {
+                    "nullability": undefined,
+                    "nullabilityV2": {
+                      "noEmptyCollections": true,
+                      "noNulls": true,
+                    },
+                    "propertyTypeConstraints": [],
+                  },
                   "displayMetadata": {
                     "description": undefined,
                     "displayName": "foo",
@@ -1251,7 +1258,14 @@ describe("Ontology Defining", () => {
               "aliases": [],
               "apiName": "com.palantir.foo",
               "baseFormatter": undefined,
-              "dataConstraints": undefined,
+              "dataConstraints": {
+                "nullability": undefined,
+                "nullabilityV2": {
+                  "noEmptyCollections": true,
+                  "noNulls": true,
+                },
+                "propertyTypeConstraints": [],
+              },
               "displayMetadata": {
                 "description": undefined,
                 "displayName": "foo",