Try catch subscription handlers #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nihalbhatnagar
commented
Nov 26, 2024
| @@ -45,7 +45,7 @@ export interface ObjectSetListener< | |||
| /** | |||
| * There was a fatal error with the subscription process. The subscription will close or will not be established. | |||
| */ | |||
| onError?: (errors: Array<any>) => void; | |||
| onError?: (errors: { subscriptionClosed: boolean; error: any }) => void; | |||
There was a problem hiding this comment.
Settled on a boolean here, the alternative was an enum to also be able to display the "I already tried to reconnect for you case" but I think that adds unnecessary complexity
There was a problem hiding this comment.
maybe I need to make it isSubscriptionClosed?
ericanderson
reviewed
Dec 4, 2024
| sub.listener.onChange?.(osdkObject); | ||
| } catch (error) { | ||
| this.#logger?.error(error, "Error in onChange callback"); | ||
| sub.listener.onError({ subscriptionClosed: false, error }); |
There was a problem hiding this comment.
if an error happens while in onError the whole thing still breaks, no? We need a fallback in that case.
ericanderson
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.