Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support getting metadata and contents for a Media reference property #1040

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

mnayan
Copy link

@mnayan mnayan commented Dec 6, 2024

Adds support to get contents and metadata for a media reference property.

Introduces Media type with getMetadata() and getContent() methods and necessary conversion methods from wire2SDK and tests.

@mnayan mnayan changed the title Support to get metadata and contents for a Media reference property Support getting metadata and contents for a Media reference property Dec 6, 2024
@mnayan mnayan marked this pull request as ready for review December 6, 2024 16:23
Copy link
Contributor

@ssanjay1 ssanjay1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far on quick skim, can we also add an E2E test hitting an actual stack to make sure things are working?

@@ -19,14 +19,8 @@ import type {
TimeSeriesProperty,
TimeSeriesQuery,
} from "@osdk/api";
import { TimeseriesDurationMapping } from "@osdk/api";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just deleting unused stuff here right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup.

Meghan Nayan added 2 commits December 9, 2024 09:02
@mnayan mnayan requested a review from ssanjay1 December 11, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants