-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support getting metadata and contents for a Media reference property #1040
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far on quick skim, can we also add an E2E test hitting an actual stack to make sure things are working?
@@ -19,14 +19,8 @@ import type { | |||
TimeSeriesProperty, | |||
TimeSeriesQuery, | |||
} from "@osdk/api"; | |||
import { TimeseriesDurationMapping } from "@osdk/api"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just deleting unused stuff here right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup.
Adds support to get contents and metadata for a media reference property.
Introduces
Media
type withgetMetadata()
andgetContent()
methods and necessary conversion methods from wire2SDK and tests.