Remove crypto from OSDK #1051
Merged
Remove crypto from OSDK #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nihalbhatnagar
commented
Dec 9, 2024
| @@ -275,18 +274,7 @@ export class ObjectSetListenerWebsocket { | |||
| // so we filter those out. | |||
| const readySubs = [...this.#subscriptions.values()].filter(isReady); | |||
|
|
|||
| if (readySubs.length === 0) { | |||
There was a problem hiding this comment.
This is not the behavior we want. We want to update that we have no more subscriptions so that we don't unnecessarily take up space over the wire
nihalbhatnagar
commented
Dec 9, 2024
| @@ -572,6 +565,7 @@ export class ObjectSetListenerWebsocket { | |||
|
|
|||
| #handleMessage_subscriptionClosed(payload: SubscriptionClosed) { | |||
| const sub = this.#subscriptions.get(payload.id); | |||
| if (sub == null && this.#endedSubscriptions.has(payload.id)) return; | |||
There was a problem hiding this comment.
Subscription is deleted in unsubscribe
ericanderson
previously approved these changes
Dec 10, 2024
policy-bot
bot
dismissed
ericanderson’s stale review
Invalidated by push of ee04cb7
nihalbhatnagar
commented
Dec 10, 2024
| @@ -188,7 +188,7 @@ describe("ObjectSetListenerWebsocket", async () => { | |||
| listener, | |||
| ); | |||
|
|
|||
| subReq1 = await expectSingleSubscribeMessage(ws); | |||
| subReq1 = await expectSubscribeMessages(ws, 2); | |||
There was a problem hiding this comment.
Empty subscribe messages are now sent
ericanderson
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React-native has issues with dependencies on crypto. Removes our polyfill and usage in object set watcher. Also fixes a small bug that can cause issues with unsubscribing with multiple subscriptions