Use foundry-config-json in widget-manifest-vite-plugin #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzyl
commented
Dec 11, 2024
| for ( | ||
| const [template, sdkVersion] of [ | ||
| ...templatesWithSdkVersions(TEMPLATES), | ||
| ...templatesWithSdkVersions(WIDGET_TEMPLATES), |
There was a problem hiding this comment.
There were a bunch of places here not applying properly to the widget templates so weren't actually beingg enforced at CI time
| @@ -159,7 +154,7 @@ export function FoundryWidgetVitePlugin(options: Options = {}): Plugin { | |||
| body += readResult; | |||
| } | |||
| }); | |||
| req.on("end", () => { | |||
| req.on("end", async () => { | |||
There was a problem hiding this comment.
Not sure if this works hoping you'll take over for dev mode
| @@ -508,7 +488,7 @@ export function FoundryWidgetVitePlugin(options: Options = {}): Plugin { | |||
| })) | |||
| : [], | |||
| rid: entrypointFileIdToConfigMap[chunk.facadeModuleId].rid, | |||
| version: packageJsonFile.version ?? "0.0.0", | |||
| version: widgetVersion, | |||
There was a problem hiding this comment.
This seems to be fine, running build on the examples package does generate the manifest in the dist folder
tzyl
force-pushed
the
tl/split-foundry-config-json
branch
from
39cabf7 to
780ad87
Compare
tzyl
force-pushed
the
tl/manifest-plugin-git-describe-strategy
branch
from
f2ec00d to
4cc9cf0
Compare
tzyl
force-pushed
the
tl/manifest-plugin-git-describe-strategy
branch
from
4cc9cf0 to
d1adf86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #1054
Replace manual package json auto version strategy and foundry config json parsing in
@osdk/widget-manifest-vite-pluginwith the shared@osdk/foundry-config-jsonpackage. This means we can use the git describe strategy now for populating the manifest at build time.