Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix onOutOfDate handler from firing twice #1071

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Fix onOutOfDate handler from firing twice #1071

merged 2 commits into from
Dec 18, 2024

Conversation

nihalbhatnagar
Copy link
Contributor

No description provided.

ssanjay1
ssanjay1 reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@ssanjay1 ssanjay1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to unblock, do we have any tests that check for this?

@bulldozer-bot bulldozer-bot bot merged commit b773513 into main Dec 18, 2024
8 checks passed
@bulldozer-bot bulldozer-bot bot deleted the nihalb/fix-osw-bug branch December 18, 2024 21:41
@nihalbhatnagar
Copy link
Contributor Author

@ssanjay1 We don't have one specifically, I will write one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssanjay1 ssanjay1 ssanjay1 approved these changes

Assignees
No one assigned
Labels
merge when ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nihalbhatnagar @ssanjay1