Add @osdk/create-app package #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzyl
commented
Jan 31, 2024
| @@ -0,0 +1,62 @@ | |||
| { | |||
| "name": "create-osdk-app", | |||
| "private": true, | |||
There was a problem hiding this comment.
Will turn on publishing in a separate step
| "transpile": "tsup", | ||
| "transpileWatch": "tsup --watch", | ||
| "typecheck": "tsc-absolute --build", | ||
| "update-snapshots": "UPDATE_SNAPSHOTS=true vitest run" |
There was a problem hiding this comment.
This is the only custom script in the package all others are the same as monorepolint
packages/create-osdk-app/src/cli.ts
Outdated
|
|
||
| consola.info(`Copying files into project directory`); | ||
|
|
||
| const templatesDir = findUpSync("templates", { |
There was a problem hiding this comment.
Originally this had a hardcoded relative path but this is slightly different now running from test or bundle:
When run in vitest this looks for create-osdk-app/src/cli.ts -> create-osdk-app/templates
When run in tsup bundle this looks for create-osdk-app/build/js/index.mjs -> create-osdk-app/templates
styu
reviewed
Jan 31, 2024
mfedderly
reviewed
Jan 31, 2024
styu
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial code for package for CLI to bootstrap OSDK apps with guided prompts and multiple tempaltes rather than cloning a starter repo and following instructions to update multiple files