Fix version adjusting logic for snapshots #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericanderson
force-pushed
the
ea.fix.builds
branch
from
d6d6258 to
826d798
Compare
ssanjay1
approved these changes
Apr 11, 2024
ericanderson
force-pushed
the
ea.fix.builds
branch
from
826d798 to
bf6ba2a
Compare
ericanderson
added a commit
that referenced
this pull request
Apr 19, 2024
* origin/main: Ea.release script (#203) Add pivot to for 1.1 (#158) Rename bulk actions to batch actions (#163) Make sure we publish with tags for snapshots (#194) Fix version adjusting logic for snapshots (#190) Maybe fix flaky test (#191) Make sure we catch pnpm build failures before merge (#189) Change release process and automate version updates (#188)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version bumps with snapshots have
-whateverin them which breaks the semver logic. We are instead just assuming its a release version to get through it.This also fixes a bug in the logic for auto version updating.
This change also pushes the version expected for generated code into one central place per generated sdk which should prevent future repo churn as we rev client versions.