Update api-gateway definitions #38
Conversation
…ctTypeFullMetadata and markings property type
| @@ -69,7 +70,7 @@ function wireActionParameterV2ToSdkParameterDefinition( | |||
| case "array": | |||
| return { | |||
| multiplicity: true, | |||
| type: actionPropertyToSdkPropertyDefinition(value.dataType), | |||
| type: actionPropertyToSdkPropertyDefinition(value.dataType.subType), | |||
There was a problem hiding this comment.
Pretty sure this was just wrong before
| @@ -0,0 +1,71 @@ | |||
| /* | |||
| * Copyright 2023 Palantir Technologies, Inc. All rights reserved. | |||
There was a problem hiding this comment.
| * Copyright 2023 Palantir Technologies, Inc. All rights reserved. | |
| * Copyright 2024 Palantir Technologies, Inc. All rights reserved. |
There was a problem hiding this comment.
@ericanderson do we have eslint set up for the copyright header?
There was a problem hiding this comment.
Its in monorepo/eslint-config-sane/library.cjs. We should probably split that into its own PR through.
| "com.palantir.foundry.api:api-gateway": { | ||
| "minVersion": "1.763.0", | ||
| "maxVersion": "1.x.x" | ||
| } |
There was a problem hiding this comment.
just so i understand, is this so this will propagate to the asset that the generator is included in? apologies i hadn't been following ultra closely
There was a problem hiding this comment.
This is halfway to that. Right now we're just adding it to @osdk/gateway so that anyone that depends on that will get it in their package tree so our internal code should pick this up. It doesn't wind up on the package built by foundry-sdk-generator OR the create-osdk-app assets.
There was a problem hiding this comment.
ok great, thanks for explaining! that's what I was hoping for
|
|
||
| /** | ||
| * One or more of the requested object types are not synced into the ontology. Please reach out to your Ontology | ||
| * Administrator to re-index the object type(s) in Ontology Management Application. |
There was a problem hiding this comment.
in theory this should only happen the very first time the object type is not synced
| * Administrator to re-index the object type(s) in Ontology Management Application. | |
| * Administrator to index the object type(s) in Ontology Management Application. |
There was a problem hiding this comment.
This is just autogenerated from the upstream docs, we don't control it.
There was a problem hiding this comment.
i can clearly read the file path, my bad
…tions * origin/main: Update api-gateway definitions (#38) Update copyright to use new Date() (#66) fix generate type restrict object : add bulk no params options Autorelease Autorelease Update ExitProcessError tips and use option instead of argument (#63) Harmonize usage of options `foundryUrl` & `clientId` across all cli commands (#50) Address minor TODOs (#55) CLI error tips (#61) Include repository link in package.json (#60) Handle version/autoVersion selection in the parsing layer (#52) Add generated changelog entries Add helper Add generated changelog entries remove commented out code one more change add intersects Autorelease Refactor site link consola box code (#58) Prompt user for destructive commands (#56) Display site link after deploy (#57) Review CLI wording (#54) use helper function remove anys Fix bulk action type Add generated changelog entries one more refactor refactor bulk actions fix second attempt bulk actions
Additionally this adds the SLS dependency information to @osdk/gateway package.json