Add final method call to request context header #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantpark04
force-pushed
the
bryantp/add-request-context-header
branch
from
11e6c29 to
a1a7a69
Compare
bryantpark04
commented
Jul 15, 2024
bryantpark04
commented
Jul 15, 2024
| @@ -141,11 +146,23 @@ export function createObjectSet<Q extends ObjectOrInterfaceDefinition>( | |||
| asyncIter: async function*(): AsyncIterableIterator<Osdk<Q, "$all">> { | |||
| let $nextPageToken: string | undefined = undefined; | |||
| do { | |||
| const result = await base.fetchPage({ $nextPageToken }); | |||
There was a problem hiding this comment.
Was there a reason that we call base.fetchPage here instead of calling the unbound fetchPageInternal? Or is the latter also fine?
bryantpark04
force-pushed
the
bryantp/add-request-context-header
branch
from
aba07bd to
353d3ec
Compare
ssanjay1
reviewed
Jul 19, 2024
| @@ -148,7 +151,15 @@ export function createObjectSet<Q extends ObjectOrInterfaceDefinition>( | |||
| ObjectOrInterfacePropertyKeysFrom2<Q>, | |||
| boolean, | |||
| "throw" | |||
| > = await base.fetchPage({ $nextPageToken }); | |||
| > = await fetchPageInternal( | |||
There was a problem hiding this comment.
To answer your previous question, I think we used base here so we wouldn't need to duplicate the fetchPageInternal code again
ssanjay1
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.