Add interface support for foundry-sdk-generator #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssanjay1
commented
Jul 14, 2024
packages/foundry-sdk-generator/src/generate/betaClient/generatePackageJson.ts
Show resolved
Hide resolved
ssanjay1
commented
Jul 17, 2024
| exports: { | ||
| ".": { | ||
| types: "./index.d.ts", | ||
| script: { |
There was a problem hiding this comment.
I removed types from the script block based on conversation with @ericanderson
ssanjay1
commented
Jul 17, 2024
| @@ -32,6 +32,7 @@ | |||
| "dependencies": { | |||
| "@osdk/api": "workspace:~", | |||
| "@osdk/client": "workspace:~", | |||
| "@osdk/client.api": "workspace:~", | |||
There was a problem hiding this comment.
Added this so that the generated packages from tests would correctly populate client.api version in the package.jsons
| default: "./ontology/objects/index.js", | ||
| dependencies: packageDeps, | ||
| } | ||
| : { |
There was a problem hiding this comment.
The fallback block is unchanged right?
There was a problem hiding this comment.
Yes, besides me pulling out the dependencies into that helper function
| @@ -51,6 +52,12 @@ export class OntologyMetadataResolver { | |||
| ) => expectedEntities.objectTypes.has(objectTypeApiName.toLowerCase())), | |||
| ); | |||
|
|
|||
| const filteredInterfaceTypes = Object.fromEntries( | |||
There was a problem hiding this comment.
Can we only add these for 2.x? That way you have to get all the way to 2.0 to use them and we can reduce 1.x support burden.
ericanderson
approved these changes
Jul 17, 2024
bryantpark04
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.