Add more exports to client #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssanjay1
commented
Jul 22, 2024
|
|
||
| export { ActionValidationError } from "./actions/ActionValidationError.js"; | ||
| export { isOk } from "./ResultOrError.js"; |
There was a problem hiding this comment.
So we originally exporting this which I don't think we're actually using anywhere?
changed it to use this:| export { PalantirApiError } from "@osdk/shared.net.errors"; | ||
|
|
||
| export type { Client } from "./Client.js"; | ||
| export { createClient } from "./createClient.js"; | ||
| export { createPlatformClient } from "./createPlatformClient.js"; | ||
|
|
||
| export { createAttachmentFromRid } from "./createAttachmentFromRid.js"; | ||
| export { createAttachmentUpload } from "./object/AttachmentUpload.js"; |
There was a problem hiding this comment.
Need this if someone wants to upload a blob to an action. The AttachmentUpload type should also accept the File object from FileApi but we need to provide this helper for now because that doesn't come standard yet
| WhereClause, | ||
| } from "@osdk/client.api"; | ||
|
|
||
| export { isOk } from "@osdk/client.api"; |
There was a problem hiding this comment.
See below on why this got swapped
| @@ -27,16 +27,19 @@ export type { | |||
| OsdkActionParameters, | |||
| OsdkObject, | |||
| PageResult, | |||
| Result, | |||
There was a problem hiding this comment.
If someone uses fetchPageWithError the type is wrapped with Result, so thought it best to expose here
ericanderson
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.