Adds version compatibility checks to Queries #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericanderson
force-pushed
the
ea/query-versionbound
branch
from
bb60e34 to
65aee7e
Compare
ericanderson
force-pushed
the
ea/query-versionbound
branch
from
65aee7e to
9a4d09b
Compare
ssanjay1
reviewed
Jul 26, 2024
| }); | ||
|
|
||
| it("callsQueryAcceptsObject", { timeout: 10_000 }, async () => { | ||
| const { resp } = await tsServer.sendQuickInfoRequest({ |
There was a problem hiding this comment.
This is pretty cool, so how do you imagine we'd expand these types of tests? I'm just trying to understand the scope of things we'd be looking for
There was a problem hiding this comment.
this is how vscode does stuff basically so anything you can visually see in vscode we can test this way
ssanjay1
reviewed
Jul 26, 2024
| @@ -45,7 +45,7 @@ export type QuerySignatureFromDef<T extends QueryDefinition<any, any>> = | |||
|
|
|||
| export type QueryParameterType< | |||
| T extends Record<any, QueryDataTypeDefinition<any, any>>, | |||
| > = NOOP<PartialByNotStrict<NotOptionalParams<T>, OptionalQueryParams<T>>>; | |||
There was a problem hiding this comment.
Why remove the NOOP? I remember when you explained this to me, it was to help expand the type out right,e.g. when you hovered over it, or am I misremembering?
There was a problem hiding this comment.
NOOP, while producing a simpler intellisense was also stripping out the mapped jsdoc. We will have to find another way possibly!
ssanjay1
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, I have added mapped description to query params and a TEST!! to ensure we don't break it.
Fixes #505