-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix legacy long aggregations #523
Changes from all commits
b6aab08
62aa962
15d50cb
8721e12
d2419ac
248b04b
9e6076f
0febab4
5116c70
f07a1ac
cf6d608
9dc9369
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
"@osdk/e2e.generated.1.1.x": minor | ||
"@osdk/legacy-client": minor | ||
"@osdk/shared.test": minor | ||
"@osdk/generator": minor | ||
--- | ||
|
||
Fix long aggregations in legacy-client |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
/* | ||
* Copyright 2024 Palantir Technologies, Inc. All rights reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
declare const representsLong: unique symbol; | ||
|
||
/** Represents a long property value converted to a string. We use a | ||
* tagged type to distinguish from a regular string property value. | ||
* This type is not used in `ValidLegacyBaseQueryDataTypes` or | ||
* `ValidLegacyActionParameterTypes` because it is just for result | ||
* long values, not long values that are passed into queries and actions. */ | ||
export type StringLong = string & { [representsLong]: true }; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Used a tagged type to disambiguate between string-type properties and strings that represent long-type properties There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we leave a comment in the code here to explain this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the main change that adds numerical aggregation support back to long-type properties