Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS Docs #533

Merged
merged 10 commits into from
Aug 20, 2024
Merged

JS Docs #533

merged 10 commits into from
Aug 20, 2024

Conversation

ssanjay1
Copy link
Contributor

No description provided.

@ssanjay1 ssanjay1 marked this pull request as ready for review August 1, 2024 15:21
@ssanjay1 ssanjay1 changed the title JS Docs WIP JS Docs Aug 1, 2024
@@ -400,9 +398,10 @@ export type GroupByRange<T> = [T, T];
export interface InterfaceObjectSet<Q extends InterfaceDefinition<any, any>> extends MinimalObjectSet<Q> {
}

// Warning: (tsdoc-param-tag-missing-hyphen) The @param block should be followed by a parameter name and then a hyphen
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we fix this before merging?

@ssanjay1 ssanjay1 merged commit a2c7b37 into main Aug 20, 2024
7 checks passed
@ssanjay1 ssanjay1 deleted the ssanjay/addJsDocs branch August 20, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants