Clean up where clause types #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssanjay1
commented
Nov 20, 2024
| @@ -15,8 +15,7 @@ | |||
| */ | |||
|
|
|||
| import type { | |||
| GeoFilter_Intersects, | |||
There was a problem hiding this comment.
Cannot remove these two types from api package because that would be a break
There was a problem hiding this comment.
So why can we remove them?
There was a problem hiding this comment.
Wait I didn't remove them from the api package exports? Just removed our use of it internally here
ericanderson
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up where clause types to use new ones we created.