Change AQE default minPartitionNum to defaultParallelism #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…min partitions as parameters
…efaultParallelism
lwwmanning
reviewed
Apr 30, 2020
sql/core/src/test/scala/org/apache/spark/sql/execution/ReduceNumShufflePartitionsSuite.scala
Outdated
Show resolved
Hide resolved
robert3005
reviewed
Apr 30, 2020
| @@ -523,6 +525,38 @@ class ReduceNumShufflePartitionsSuite extends SparkFunSuite with BeforeAndAfterA | |||
| } | |||
| } | |||
|
|
|||
| // TODO(rshkv): Remove after taking SPARK-31124 | |||
There was a problem hiding this comment.
please file an issue and reference it here
robert3005
changed the title
robert3005
changed the title
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying changes from SPARK-31124 / apache/spark#27879.
What changes were proposed in this pull request?
Authoritative description on apache/spark#27879.
Summary: When coalescing partitions in AQE, the minimum is no longer 1 but default parallelism. The default parallelism is
spark.default.parallelismwhen set or the number of available CPUs at any given point in time. This ensures that we don't lose parallelism by applying AQE.Why didn't you just take the upstream commit? The AQE framework was refactored in SPARK-31037, which in turn relies on changes we haven't picked yet. And the sum of those was more than I felt comfortable with taking in one batch. So yes this is lame. We can just revert this later.
How was this patch tested? I wrote a unit test which ensures that the partition number is the default parallelism value where it would otherwise be 1.