Implement the access control feature for Paltalabs #54
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hello @apptreeso @chopan123
|
| // This function should be called once when the contract is deployed | ||
| pub fn init(env: Env, admin: Address, title: String) { | ||
| if env.storage().instance().has(&AdminInfo::Initialized) { | ||
| panic!("contract already initilized") |
|
Good simple implementation of the access control! I like that the contract is tested in multiple scenarios! But frontend is not even compiling on development... |
I missed to commit one file. I just added it and create a new PR. It works fine. Would you check it? |
|
Hello @apptreeso your deployment is still failing |
There was a problem hiding this comment.
Nice to have onchain tests with chai.
it would be nice to test that another address cannot change the title
| } | ||
|
|
||
| #[test] | ||
| fn test_set_title_by_owner() { |
There was a problem hiding this comment.
Here you are mocking all auths, thats why is working
|
Hello @apptreeso I reviewed your submission. 1.- You didnt implement any address management, neither on smart contract side, neither on the frontend. 2.- Your preview is failing. As I said, you can check if it will fail by just doing |
No description provided.