"My first dapp, check readme" #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I stayed motivated by the challenge, so I made some additional improvements to my initial code c: |
esteblock
requested changes
Aug 30, 2024
| } | ||
|
|
||
| #[test] | ||
| fn test_modify_title() { |
There was a problem hiding this comment.
There is no test to indeed see that the auth control is working
…rove ManageTitle component - Updated README.md with comprehensive instructions on setting up the application, deploying the smart contract, and configuring the admin user. - Deployed the smart contract to the Stellar blockchain using Soroban. - Enhanced ManageTitle.tsx component: - Implemented automatic refresh for the list of authorized users. - Added automatic form field clearing after actions like adding a user, modifying the admin, or changing the title. - Improved semantic HTML structure: set contract section titles with larger, bold font.
esteblock
reviewed
Sep 11, 2024
| let user = Address::generate(&env); | ||
|
|
||
| // Autenticar y setear al admin | ||
| client.mock_auths(&[MockAuth { |
There was a problem hiding this comment.
Esta bien mockeado el auth, pero para testear se deberían revisar las ultimas auths y confirmar que la auth realmente existió. Esto esta mejor que antes de toda maneras
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.