Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/refactor ux #213

Merged
merged 15 commits into from
Nov 20, 2024
Merged

Fix/refactor ux #213

merged 15 commits into from
Nov 20, 2024

Conversation

MattPoblete
Copy link
Collaborator

@MattPoblete MattPoblete commented Nov 19, 2024

This fix includes:

  • Select Strategies should not load when clicked, it should not call the blockchain... Strategies should come in a json with this format so we dont need to call the blockchain for info
    [ { name: <StrategyName> address: <Address>, asset: { code: <Symbol> address: <Address> } }, { name: <StrategyName> strategy: <Address>, asset: { code: <Symbol> address: <Address> } } ]
  • When selecting Strategies and i already have it added, it should get inactive when trying to add another since its already added-
  • Modal closes out of nowhere if you take for too long.
  • When deploying a vault and then another without refreshing the page, some things like Vault Name, Symbol, initial amount, etc dont get reseted if i then try to deploy another vault and the first was deployed with initial amount ON and then i try to deploy another one and dont select the initial amount checkbox it gets added anyway, i'm guessing it's because of the previous one having it.
  • After deploying a vault and then the signing transaction modal closes the vault appears in the list but if i click it i get an error in apps/dapp/src/components/ManageVaults/InspectVault.tsx (76:38) @ InspectVault, > 76 | {selectedVault.idleFunds.map((asset: AssetAmmount, index: number) => ( Cannot read properties of undefined "map" if i reload the page it works fine.
  • When depositing when the transaction is succesfull it should reload the vault amounts, same with withdrawal and emergency withdrawal, same for invest in the future.
  • When i open a Vault modal, i should be able to click it and copy it.

Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
defindex-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 1:56pm
defindex-landing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 1:56pm
defindex-rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 1:56pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment