Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Update deposit tests #238

Merged
merged 4 commits into from
Dec 2, 2024
Merged

⬆️ Update deposit tests #238

merged 4 commits into from
Dec 2, 2024

Conversation

MattPoblete
Copy link
Collaborator

Add amounts = 0 test
Add overflow test
Add amount min > desired amount

@MattPoblete MattPoblete linked an issue Nov 26, 2024 that may be closed by this pull request
Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
defindex-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 11:56am
defindex-landing ❌ Failed (Inspect) Nov 29, 2024 11:56am
defindex-rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 11:56am

@chopan123
Copy link
Member

chopan123 commented Nov 26, 2024

  • Try to deposit more than you have
  • Try to deposit an unsupported asset

@MattPoblete
Copy link
Collaborator Author

MattPoblete commented Nov 26, 2024

  • Try to deposit an unsupported asset

Cant deposit an unsupported asset because we just send amounts, the vault manages directly the asset transfer
image

Copy link
Member

@chopan123 chopan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parece que tambien el package.json

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se te quedó este archivo de la otra rama

Copy link
Member

@chopan123 chopan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parece que tambien el package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 [vault] Include deposit tests that should fail
2 participants