Scheduler passes results path to experiment file #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andnp
reviewed
Oct 31, 2024
| @@ -41,6 +41,7 @@ def __init__(self, exp_name: str, seeds: list[int], entry: str, version: Version | |||
| self.seeds = seeds | |||
| self.entry = entry | |||
| self.base_path = base or os.getcwd() | |||
| self.results_path = os.path.join(self.base_path, 'results', self.exp_name) | |||
There was a problem hiding this comment.
I recently learned of from pathlib import Path which is part of the standard library: https://docs.python.org/3/library/pathlib.html
Let's you do some of this path manipulation stuff like this:
self.results_path = Path(self.base_path) / 'results' / self.exp_namewhich is pretty nice. Generally just simplifies filesystem related things a lot.
Anyways, no action item here (i.e. really no need to change this code), just thought I'd share!
There was a problem hiding this comment.
Oh cool!! I am always confused about which Path objects you can use as strings and which you cannot (PosixPath?). Thanks for the review!
andnp
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23