Scheduler #10
Merged
Scheduler #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panahiparham
commented
Oct 23, 2024
panahiparham
commented
Oct 23, 2024
|
|
||
| @dataclass | ||
| class RunConfig: | ||
| ... |
There was a problem hiding this comment.
This commit does not contain the slurm functionality but the parent RunConfig is still defined here. I guess this is fine?
There was a problem hiding this comment.
Yup, I think that's just fine!
I typically try to avoid defining generic interfaces before they are needed, but in this case we know that this will be needed in a follow-up PR.
panahiparham
commented
Oct 23, 2024
|
|
||
|
|
||
| def _run_single(self, r: RunSpec) -> None: | ||
| subprocess.run(['python', self.entry, '--part', r.part_name, '--config-id', str(r.config_id), '--seed', str(r.seed), '--version', str(r.version)]) |
There was a problem hiding this comment.
In the upcoming steps we should work on a sample main file that uses these parameters to properly setup the ml_instrumentation library for data saving and loading.
panahiparham
force-pushed
the
scheduler
branch
from
a1b3848 to
d45da00
Compare
andnp
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #6 by adding a
Schedulerclass that extracts the configurations from the metadata database and runs the experiments locally. The first two commits are small utilities that support the third and longer commit that implements theSchedulerclass.