[Part 3 of 3] Code factoring (s43, s48, s50) #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChefMist
changed the title
chefburger
approved these changes
Jan 27, 2025
ChefMist
added a commit
that referenced
this pull request
Jan 27, 2025
* feat: increase optimizer runs * [Part 3 of 3] Code factoring (s43, s48, s50) (#76) * s43: interface doc update * s48: use directive with global * s50: use internal keyword to make visibility obvious
ChefMist
added a commit
that referenced
this pull request
Jan 27, 2025
…#74) * feat: update v4-core * feat: lower the run count * feat: set stable and update update foundry run count * feat: use native gas snapshot * [Part 2 of 3] Increase optimizer runs (s41) (#75) * feat: increase optimizer runs * [Part 3 of 3] Code factoring (s43, s48, s50) (#76) * s43: interface doc update * s48: use directive with global * s50: use internal keyword to make visibility obvious
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
s43: add comment to code based on natspec format
s48: use directive with global eg.
using Planner for Plan global;so we don't have to typeusing Planner for Plans50: use
internal constantto make it obvious (and follow other files convention)