Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Part 3 of 3] Code factoring (s43, s48, s50) #76

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

ChefMist
Copy link
Collaborator

This PR does the following:

  • s43: add comment to code based on natspec format

  • s48: use directive with global eg. using Planner for Plan global; so we don't have to type using Planner for Plan

  • s50: use internal constant to make it obvious (and follow other files convention)

@ChefMist ChefMist changed the title [Part 3 of 3] Code factoring [Part 3 of 3] Code factoring (s43, s48, s50) Jan 26, 2025
@ChefMist ChefMist merged commit 7b365b8 into feat/part-2-optimizer_runs Jan 27, 2025
2 checks passed
@ChefMist ChefMist deleted the feat/part-3-code-refactor branch January 27, 2025 04:53
ChefMist added a commit that referenced this pull request Jan 27, 2025
* feat: increase optimizer runs

* [Part 3 of 3] Code factoring (s43, s48, s50) (#76)

* s43: interface doc update

* s48: use directive with global

* s50: use internal keyword to make visibility obvious
ChefMist added a commit that referenced this pull request Jan 27, 2025
…#74)

* feat: update v4-core

* feat: lower the run count

* feat: set stable and update update foundry run count

* feat: use native gas snapshot

* [Part 2 of 3] Increase optimizer runs (s41) (#75)

* feat: increase optimizer runs

* [Part 3 of 3] Code factoring (s43, s48, s50) (#76)

* s43: interface doc update

* s48: use directive with global

* s50: use internal keyword to make visibility obvious
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants