feat: add v4-periphery deployment address #2
Conversation
| if (NFTPositionDescriptorProxy == address(0)) { | ||
| revert InvalidProxyAddress(); |
There was a problem hiding this comment.
not required as getAddressFromConfig will throw error if address not set
There was a problem hiding this comment.
i think this is the purpose why added the error.
If you did not set the address , will get this error.
There was a problem hiding this comment.
I agree with Mist, It's fine if getAddressFromConfig already covers it
There was a problem hiding this comment.
yeh it was my bad @ChefSnoopy -- the original BaseScript validation seems to be no longer working.. i just checked today when deploying v4-core and it seems to decode both "" and "0x" as 0x20 for empty address
which explain the changes here https://github.com/pancakeswap/pancake-v4-periphery/pull/2/files#diff-0f008501c3a9e80366f57118bc1631e5b975a40ee503a9617505689b8e9cb7d1R25
|
since https://github.com/pancakeswap/pancake-v4-periphery/pull/3 is approved, will wait for that PR to be merged and then re-deploy and update this PR |
Follow-up PR from https://github.com/pancakeswap/pancake-v4-core/pull/7
v4-peripheryonSepoliaBaseScriptfor proper validationOnce its merged, will