Fix issue with Tempita recompilation #57796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
force-pushed
the
fix-recompilation
branch
from
4f7ae19 to
2b79d19
Compare
rhshadrach
approved these changes
Mar 13, 2024
|
@lithomas1 - thought you might want to review. |
|
No objections here - I think adding the files as sources was originally a hack to workaround a bug in meson. |
mroeschke
approved these changes
Mar 13, 2024
|
Thanks @WillAyd |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Mar 13, 2024
mroeschke
pushed a commit
that referenced
this pull request
Mar 14, 2024
…ion) (#57834) Backport PR #57796: Fix issue with Tempita recompilation Co-authored-by: William Ayd <[email protected]>
|
The more I have used this the less I am sure that it actually fixed the issue. Whenever I edit a tempita file now it does not trigger a recompilation as it should |
WillAyd
added a commit
to WillAyd/pandas
that referenced
this pull request
Mar 18, 2024
This reverts commit 97c31a6.
mroeschke
pushed a commit
that referenced
this pull request
Mar 19, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Mar 19, 2024
mroeschke
pushed a commit
that referenced
this pull request
Mar 19, 2024
…compilation (#57796)") (#57907) Backport PR #57905: Revert "Fix issue with Tempita recompilation (#57796)" Co-authored-by: William Ayd <[email protected]>
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
Fix dependency issue with Tempita file outputs
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
…das-dev#57905) This reverts commit 97c31a6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref mesonbuild/meson-python#589 (comment) @rhshadrach I think you mentioned this originally on Slack