Bugfix : Added mathjax_ignore to HTMLFormatter._write_table and changed tests to assert mathjax_ignore
#60043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attack68
approved these changes
Oct 15, 2024
|
/preview |
|
@datapythonista - the https://github.com/pandas-dev/pandas/actions/runs/11469095078/job/31915606006 Should I open an issue? |
rhshadrach
requested changes
Oct 22, 2024
pandas/io/formats/style_render.py
Outdated
| @@ -366,9 +366,11 @@ def _translate( | |||
| if not get_option("styler.html.mathjax"): | |||
| table_attr = table_attr or "" | |||
| if 'class="' in table_attr: | |||
| table_attr = table_attr.replace('class="', 'class="tex2jax_ignore ') | |||
| table_attr = table_attr.replace( | |||
| 'class="', 'class="tex2jax_ignore mathjax_ignore"' | |||
There was a problem hiding this comment.
This should be
'class="', 'class="tex2jax_ignore mathjax_ignore '
as we are prepending to an already existing class.
Co-authored-by: Richard Shadrach <[email protected]>
Fixed error in prepending existing class in table_attr
attack68
reviewed
Oct 24, 2024
pandas/io/formats/style_render.py
Outdated
| else: | ||
| table_attr += ' class="tex2jax_ignore"' | ||
| table_attr += 'class="tex2jax_ignore mathjax_ignore"' |
There was a problem hiding this comment.
There is a reason for this space at the start.
attack68
reviewed
Oct 24, 2024
pandas/io/formats/style_render.py
Outdated
| else: | ||
| table_attr += ' class="tex2jax_ignore"' | ||
| table_attr += 'class="tex2jax_ignore mathjax_ignore"' |
There was a problem hiding this comment.
Suggested change
| table_attr += 'class="tex2jax_ignore mathjax_ignore"' | |
| table_attr += ' class="tex2jax_ignore mathjax_ignore"' |
|
This PR seems to have gone stale, can I take over this issue? Thanks |
|
@KevsterAmp - sounds good. |
rhshadrach
requested changes
Nov 9, 2024
| @@ -366,9 +366,11 @@ def _translate( | |||
| if not get_option("styler.html.mathjax"): | |||
| table_attr = table_attr or "" | |||
| if 'class="' in table_attr: | |||
| table_attr = table_attr.replace('class="', 'class="tex2jax_ignore ') | |||
| table_attr = table_attr.replace( | |||
| 'class="', ' class="tex2jax_ignore mathjax_ignore ' | |||
There was a problem hiding this comment.
Suggested change
| 'class="', ' class="tex2jax_ignore mathjax_ignore ' | |
| 'class="', 'class="tex2jax_ignore mathjax_ignore ' |
|
@rhshadrach - Do I commit on this branch or I re-open a new PR? Thanks |
|
Thanks for this PR, but the issue was closed by #60311 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Feedback would be appreciated.