Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Add test for x-axis labels in subplot with secondary_y=True #60294

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

jasonmokk
Copy link
Contributor

@jasonmokk jasonmokk commented Nov 13, 2024

This PR adds a unit test to pandas/tests/plotting/test_series.py to verify that X-axis labels are preserved when using secondary_y=True and creaitng a new subplot. Adds a test for the solved issue described in #14102.

@jasonmokk jasonmokk force-pushed the test-secondary-y-x-axis-labels branch 5 times, most recently from e2071cb to 1ede739 Compare November 13, 2024 06:11
@jasonmokk jasonmokk changed the title TST: Add test for x-axis labels in subplots with secondary_y=True TST: Add test for x-axis labels in subplot with secondary_y=True Nov 13, 2024
TST: Add test for x-axis labels in subplots with secondary_y=True

TST: Add test for x-axis labels in subplots with secondary_y=True

TST: Add test for x-axis labels in subplots with secondary_y=True

TST: Add test for x-axis labels in subplots with secondary_y=True
@jasonmokk jasonmokk force-pushed the test-secondary-y-x-axis-labels branch from 1ede739 to 178f9ab Compare November 13, 2024 06:11
@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Visualization plotting labels Nov 13, 2024
@mroeschke mroeschke added this to the 3.0 milestone Nov 14, 2024
@mroeschke mroeschke merged commit 45aa7a5 into pandas-dev:main Nov 14, 2024
51 checks passed
@mroeschke
Copy link
Member

Thanks @jasonmokk

@jasonmokk jasonmokk deleted the test-secondary-y-x-axis-labels branch November 14, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite Visualization plotting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No labels on X-axis on charts with secondary_y=True
2 participants