Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add trim() to github.event.comment.body on issue_assign workflow job #60359

Merged

Conversation

KevsterAmp
Copy link
Contributor

@KevsterAmp KevsterAmp force-pushed the trim-github-comment-issue-assign-workflow branch from 46525c9 to 6f6d468 Compare November 19, 2024 01:03
@KevsterAmp KevsterAmp marked this pull request as draft November 19, 2024 01:03
@KevsterAmp KevsterAmp changed the title ENH: add trim() to github.event.commend.body on issue_assign workflow job ENH: add trim() to github.event.comment.body on issue_assign workflow job Nov 19, 2024
@KevsterAmp KevsterAmp marked this pull request as ready for review November 21, 2024 05:50
@mroeschke mroeschke added the CI Continuous Integration label Nov 21, 2024
@mroeschke mroeschke added this to the 3.0 milestone Nov 21, 2024
@mroeschke mroeschke merged commit f105eef into pandas-dev:main Nov 21, 2024
53 checks passed
@mroeschke
Copy link
Member

Thanks @KevsterAmp

@asishm
Copy link
Contributor

asishm commented Nov 22, 2024

not super familiar with gha - but this doesn't seem to be working. I mean, I don't like the notification spam. unclear whether that's expected.

The workflow is not valid. .github/workflows/comment-commands.yml (Line: 14, Col: 9): Unrecognized function: 'trim'. Located at position 39 within expression: (!github.event.issue.pull_request) && trim(github.event.comment.body) == 'take'

see: https://github.com/pandas-dev/pandas/actions/runs/11973220181/workflow

@KevsterAmp
Copy link
Contributor Author

@asishm - Thanks for the report, confirmed that I can't also use take as of the moment. I'll open an issue and create a PR to revert this. From further investigation, looks like github workflows doesn't have any trim or similar related function in the docs. I guess the original CI would be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Strip/Trim github.event.comment.user.login on issue_assign job in comment_commands.yml
3 participants