allow SVG for any document format but keep high priority in non-PDF #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now SVG (image/svg+xml) cannot be selected as a valid format for a diagram if the document output format is latex/context (so PDF as well). As pandoc can convert SVG into some compatible format using `rsvg-convert`, This allows the SVG format to be in the `preferred_mime_types` list. The previous behavior with non-PDF output formats is kept as is (raising the SVG format priority in the `preferred_mime_types` list).
|
Thanks for the PR and apologies for the late reply. I'm not sure I understand why this change would be needed/what the benefits are of allowing SVG for PDF output. Does it just change the converter from inkscape to rsvg-convert, or is there more to it? |
|
For what I understand from the code, inkscape is used to convert pdf to svg, not include SVG into a PDF output of pandoc. having the diagram generation program able to output SVG and then convert it properly with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now SVG (image/svg+xml) cannot be selected as a valid format for a diagram if the document output format is latex/context (so PDF as well).
As pandoc can convert SVG into some compatible format using
rsvg-convert, This allows the SVG format to be in thepreferred_mime_typeslist.The previous behavior with non-PDF output formats is kept as is (raising the SVG format priority in the
preferred_mime_typeslist).