-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements cetz diagrams #37 #38
Conversation
The filter works with pandoc, but recent changes in the filter makes it fail with quarto see #39. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! The only request I have is about something minor in the docs 😅
@@ -80,6 +80,7 @@ that can be used to specify a specific executable. | |||
| [Mermaid] | `mermaid` | `mmdc` | `MERMAID_BIN` | | |||
| [PlantUML] | `plantuml` | `plantuml` | `PLANTUML_BIN` | | |||
| [Ti*k*Z] | `tikz` | `pdflatex` | `PDFLATEX_BIN` | | |||
| [cetz] | `cetz` | `typst` | `TYPST_BIN` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package itself seems to use the capitalization CeTZ
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, done.
Oh, and running the test during CI would be good, too. There seems to be a typst package available on Alpine, so using |
c2d80b2
to
6c207dc
Compare
I've added the CI action using quarto image to use their built-in typst program. |
9874a49
to
2c90f08
Compare
oh, that's a neat approach! It should be possible to set the executable in the metadata, something along the lines of diagram:
engines:
cetz:
execpath: quarto typst Then we won't have to do the "create executables" step that seems to cause issues on the GitHub workflow runners. Let me know if that doesn't work, then I'll try to make it work somehow. |
This approach do not work:
|
OK, I'll try to implement a fix. One moment. |
Please rebase to the current main and try with |
Ok I try that. |
I fixed the arguments list to use quarto typst command and changed pandoc command to use quarto's pandoc in makefile. This should be OK now. |
Thank you! I'll add the missing |
Works beautifully! I'll make a new release within the next days. |
@tarleb Thanks for your feedbacks during the pr. And again thanks for sharing this handful extension open source. |
This is a basic implementation using typst to compile cetz code to svg, png or pdf.