Update to work with JupyterLab 1.0+ and new dask extensions #13
Conversation
| @@ -1,7 +1,6 @@ | |||
| #!/bin/bash | |||
| jupyter serverextension enable --py nbserverproxy --sys-prefix | |||
| jupyter serverextension enable --py jupyter_server_proxy --sys-prefix | |||
There was a problem hiding this comment.
From what I can tell in the docs, this shouldn't be necessary when installing from pip or Conda: https://github.com/jupyterhub/jupyter-server-proxy. Does that sound correct?
There was a problem hiding this comment.
Yes, that sounds right to me.
There was a problem hiding this comment.
What would be the best/simple example to test this?
There was a problem hiding this comment.
The package uses a conf.d approach to auto-enable itself. So if you remove this line and things still work, you should be good to go.
There was a problem hiding this comment.
and things still work
Yeah, I'm asking what "things" are. I'm not using dask or the dashboards in any of my current binder-based projects. If I can make a dead simple notebook example that uses the extension I was hoping that would be a good test. Or are you saying it should be auto-enabled and if the install line below this succeeds then we can assume it works?
|
Ah, sorry, I misunderstand. I'm not aware of any notebook based tests, but you should be able to open a terminal and enter jupyter serverextension list To see whether it is properly enabled. |
|
So the first image that built after removing that line brought up an error when it started about not finding the server(s) and the extension not being installed. I mindlessly clicked "Dismiss" on the dialog so I don't have a screenshot (trying to reproduce it now). When I restarted the session I didn't get the error and when I listed the server extensions it said it was installed and enabled so. 🤷♂ |
These are changes I needed to make to get my own repository working with JupyterLab 1.0+. The main things are fixing workspace importing which no longer needs the base URL to be included and updating to use jupyter-server-proxy and dask-labextension. Note I didn't actually test the extensions and dashboards, but I didn't receive any errors when jlab opened. If anything this can be used as a reference.
This was based on help from @ian-r-rose and @TomAugspurger.