Added Battlefield 3 support and restructurized how the Connection and Packets work #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all probably we will need to change some thing before merge because I haven't tested factorio and minecraft.
Overview of changes
Connection
andPacket
, doing this I try to add extensibility to the project and let people add support to more layouts without the overhead of being careful to not break other implementations (removed builder).MinecraftConnection
PacketType
to just 3 variantsRequest
,Response
andCustom
with an asociated number, this a weak point of the PR that maybe we should change a lot.async-trait
dependency for async traits (Connection
andPacket
)Final words
For the moment the use of async capabilities we are doing are slower than syncronous io but that could change in the future. Hope you like the design and merry christmas! 🎄
This change is